Text parsing fixes#8589
Open
APickledWalrus wants to merge 4 commits intodev/patchfrom
Open
Conversation
APickledWalrus
requested review from
Absolutionism and
erenkarakal
and removed request for
a team
skriptlang-automation
Bot
added
needs reviews
This comment has been minimized.
This comment has been minimized.
sovdeeth
approved these changes
Apr 24, 2026
skriptlang-automation
Bot
added
the
bug
skriptlang-automation
Bot
removed
the
needs triage
1 task
Efnilite
approved these changes
Apr 25, 2026
github-project-automation
Bot
moved this from In Review
to Awaiting Merge
in 2.15 Releases
skriptlang-automation
Bot
added
patch-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There are several regressions introduced by the Adventure migration:
<##123456>)Solution
My good friend Regular Expression has returned to bring order to the string parsing.
Unfortunately, MiniMessage does not accept tags with two leading
##so this has to be manually handled. It is done so similarly to multi world color tags (<dark red>).I've also rewritten escaping and conversion of legacy codes/hex codes. The pattern makes it easier to handle escaped tags and adds better validation to what we convert.
Testing Completed
I added multiple JUnit regression tests.
Supporting Information
Completes:
Related: none
AI assistance: none