test: Add e2e-tests by maxreichmann · Pull Request #1355 · UI5/cli

maxreichmann · 2026-04-08T13:57:40Z

Outsourced of Incremental Build PR #1267:

Add "e2e-tests" dir under "internal/"
Add tests for following community custom tasks:
- ui5-tooling-transpile
- ui5-task-zipper
- ui5-tooling-modules
- ui5-tooling-stringreplace
Add test for "ui5 --version"

All tests are currently passing (April 8th).

* Add "e2e-tests" dir under "internal/" * Add tests for following community custom tasks: - ui5-tooling-transpile - ui5-task-zipper - ui5-tooling-modules - ui5-tooling-stringreplace * Add test for "ui5 --version"

maxreichmann · 2026-04-08T14:28:05Z

@UI5/ui5-team-cor-fnd These tests are not included in any CI pipeline yet. It's up for debate if we want to include them.

d3xter666

There's also an e2e test setup in packages/cli.
Can we leverage and consolidate the setup from there?
Or simply clean it up if it's redundant an too complex anymore?

maxreichmann · 2026-04-16T12:46:55Z

Tests are now included in Github Actions via a separate workflow (internal-e2e-tests.yml) and take about a minute of execution.

d3xter666

LGTM

RandomByte

Sorry for the late review

RandomByte · 2026-04-28T11:09:53Z

+describe("ui5 version", () => {
+	test("output the version of the UI5 CLI", ({assert}) => {
+		const ui5Path = path.resolve(__dirname, "../../../packages/cli/bin/ui5.cjs");
+		execFile("node", [ui5Path, "--version"], (error, stdout, stderr) => {


I think this test is identical to

cli/packages/cli/test/lib/cli/base.js

Line 40 in 40afbdf

const {stdout} = await ui5(["--version"]);

Do we need both?

RandomByte · 2026-04-28T11:13:40Z

+		// Install node_modules
+		await this._installNodeModules();
+		// Setup environment
+		process.env.UI5_DATA_DIR = `${this.dotUi5Path}`;


Suggested change

process.env.UI5_DATA_DIR = `${this.dotUi5Path}`;

process.env.UI5_DATA_DIR = this.dotUi5Path;

RandomByte · 2026-04-28T11:15:43Z

+		// --------------------------------------------------------------------------------------------
+
+		// Modify source files
+		await fixtureHelper.prepareForNextRun();


Why is this (deletion and fresh copy of sources) necessary here? From what I can see, the source files have not been changed?

RandomByte · 2026-04-28T11:22:54Z

@@ -0,0 +1,10 @@
+{


We should have a package-lock.json next to every package.json. Then we can also use ranges for the dependencies

RandomByte · 2026-04-28T11:37:47Z

+		// #2 Build
+		await fixtureHelper.build(assert, ui5YamlName);
+
+		// Test: the dist contains the new controller and the third party import


Can we also check whether the thirdparty itself is present in the build result? (unless it's already without the import)

RandomByte · 2026-04-28T11:40:04Z

+`sap.ui.define([], () => {
+	return Controller.extend("application.a.controller.New",{
+		onInit() {
+			console.log(\${PLACEHOLDER_TEXT});


I think this is not a good example because the result is not valid JavaScript:

console.log(\"INSERTED_TEXT\")

Just ran the test and checked the dist output of controller/New.controller.js:
sap.ui.define([],()=>Controller.extend("application.a.controller.New",{onInit(){console.log("INSERTED_TEXT")}})); //# sourceMappingURL=New.controller.js.map

Looks fine to me. Or do you mean something different?

My bad, makes sense 👍🏼

RandomByte · 2026-04-28T11:42:22Z

+		"test-watch": "node --test --watch 'test/**/*.js'"
+	},
+	"dependencies": {
+		"adm-zip": "0.5.17"


Dependency is locked via the root package-lock.json, so we can use a range here:

Suggested change

"adm-zip": "0.5.17"

"adm-zip": "^0.5.17"

RandomByte · 2026-04-28T11:43:05Z

@@ -0,0 +1,10 @@
+{
+	"name": "application.a.ts",


Use a prefix like @ui5-internal for test packages

RandomByte · 2026-04-28T11:46:58Z

+	second: string
+}
+
+export default class Main {


Should we use a proper UI5 controller that extends sap/ui/core/mvc/Controller like in https://github.com/SAP-samples/ui5-typescript-tutorial/blob/main/exercises/ex4/com.myorg.myapp/webapp/controller/BaseController.ts#L13 ?

* Remove version.js ("ui5 --version" test) * Cleanup code (remove template lit.) * Remove FixtureHelper.prepareForNextRun() and its usages * Add package-lock.json to every fixture * ui5-tooling-modules test: Add check for thirdparty module itself (ChartJS) * Add version ranges to every relevant package.json * Prefix fixture packages with "@ui5-internal" * Replace test controller with more realistic code (modified copy of ui5-typescript-tutorial)

test: Add e2e-tests

f084bc1

* Add "e2e-tests" dir under "internal/" * Add tests for following community custom tasks: - ui5-tooling-transpile - ui5-task-zipper - ui5-tooling-modules - ui5-tooling-stringreplace * Add test for "ui5 --version"

maxreichmann requested a review from a team April 8, 2026 14:27

d3xter666 requested changes Apr 9, 2026

View reviewed changes

Comment thread internal/e2e-tests/test/build.js

Comment thread internal/e2e-tests/test/build.js Outdated

Comment thread internal/e2e-tests/test/build.js Outdated

test: Ignore tmp folder in .gitignore

1e7aace

maxreichmann force-pushed the test/e2e-tests branch from c12b05a to 1e7aace Compare April 9, 2026 07:59

test: Address Review (refactor env variables + post-test cleanup)

6886c31

maxreichmann force-pushed the test/e2e-tests branch 3 times, most recently from c3d2478 to deacdaf Compare April 16, 2026 12:37

maxreichmann requested review from RandomByte and d3xter666 April 16, 2026 12:45

ci: Create workflow for internal/e2e-tests

de4fb7c

maxreichmann force-pushed the test/e2e-tests branch from deacdaf to de4fb7c Compare April 17, 2026 09:15

maxreichmann requested review from a team and removed request for RandomByte and d3xter666 April 21, 2026 08:52

d3xter666 reviewed Apr 22, 2026

View reviewed changes

Comment thread internal/e2e-tests/README.md Outdated

docs: Refactor e2e README (Address review)

630d0d2

maxreichmann requested a review from d3xter666 April 22, 2026 07:27

d3xter666 reviewed Apr 22, 2026

View reviewed changes

d3xter666 requested a review from a team April 22, 2026 07:39

RandomByte requested changes Apr 28, 2026

View reviewed changes

maxreichmann requested a review from RandomByte April 28, 2026 16:14

	process.env.UI5_DATA_DIR = `${this.dotUi5Path}`;
	process.env.UI5_DATA_DIR = this.dotUi5Path;

Conversation

maxreichmann commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maxreichmann commented Apr 8, 2026

Uh oh!

d3xter666 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maxreichmann commented Apr 16, 2026

Uh oh!

Uh oh!

d3xter666 left a comment

Choose a reason for hiding this comment

Uh oh!

RandomByte left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

maxreichmann commented Apr 8, 2026 •

edited

Loading