Improvements to RequisiteParser (Packrat Parsing)#164
Open
Yogeb-tech wants to merge 10 commits intodevelopfrom
Open
Improvements to RequisiteParser (Packrat Parsing)#164Yogeb-tech wants to merge 10 commits intodevelopfrom
Yogeb-tech wants to merge 10 commits intodevelopfrom
Conversation
…hers do not work due to being recursive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the main improvements I've made:
That said, I haven’t utilized the packrat parser as well as I should have. Ideally, each smaller parser could still keep its own regex patterns for now (change them later), but the next step would be adding a top-level packrat parser would handle AND/OR requirements, parentheses, and address any edge cases.
Currently:
ParseRequirement()still uses manual strings.Split and recursion for AND/OR, andgroupParens()to track parenthesesparseGroup()usage in choice matcher with the packrat parser could also be beneficialI would like to step away for this issue for a bit, if someone else could handle some of these changes, that would be great :)
I'm open to any suggestions or concerns about my proposed future changes.