fix: batch transform failure handling#1573
Open
CalebMartinUiPath wants to merge 2 commits intomainfrom
Open
Conversation
b00d64f to
c1c63d9
Compare
JeremyReist2
approved these changes
Apr 17, 2026
| batch_transform = self.retrieve_batch_transform( | ||
| id=id, index_name=index_name | ||
| ) | ||
| if batch_transform.last_batch_rag_status == BatchTransformStatus.FAILED: |
There was a problem hiding this comment.
does the same logic apply to DeepRAG?
gcuip
reviewed
Apr 17, 2026
| if batch_transform.last_batch_rag_status == BatchTransformStatus.FAILED: | ||
| raise BatchTransformFailedException( | ||
| batch_transform_id=id, | ||
| status=batch_transform.last_batch_rag_status, |
gcuip
reviewed
Apr 17, 2026
| ) | ||
| except BatchTransformFailedException as e: | ||
| raise UiPathFaultedTriggerError( | ||
| ErrorCategory.USER, |
Contributor
There was a problem hiding this comment.
why is this a user error? can't it be marked as failed due to other conditions in ecs?
in ecs we have:
try {
// do various async things
} catch (Exception ex)
{
ex = ex.Unwrap();
if (info != null)
{
var errorMessage = (ex as LocalizedException)?.Message
?? ErrorMessages.BatchRag_InternalFailure;
await Workflow.ExecuteLocalActivityAsync(
(IBatchRagReportingActivities a) => a.ReportFailureAsync(batchRagId, errorMessage),
new LocalActivityOptions
{
StartToCloseTimeout = TimeSpan.FromMinutes(1),
RetryPolicy = new RetryPolicy { MaximumAttempts = 3 }
});
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
failed batch transforms were being incorrectly handled as in progress. Causing the agent to loop waiting for it to finish. With this change agent execution will end properly.