Fix protein layer generation and error handling in vrs_map#95
Open
bencap wants to merge 2 commits intofeature/bencap/53/reference-identical-vrsfrom
Open
Conversation
…ilure when valid hgvs nt mapping exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refines the logic for handling protein alignment results in the
_map_protein_codingfunction, improving error handling and reducing redundant error messages. Under certain circumstances, this bug caused both nucleotide and protein mappings to be emitted rather than just a single layer.Error handling improvements:
src/dcd_mapping/vrs_map.py, src/dcd_mapping/vrs_map.pyL832-R840)