Preloading images and stylesheets: <link> vs Early Hints response header#617
Preloading images and stylesheets: <link> vs Early Hints response header#617felixarntz wants to merge 5 commits intotrunkfrom
Conversation
…Early Hints header.
…g vs Early Hints header.
felixarntz
added
[Type] Feature
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @felixarntz Left some feedback.
| if ( null !== $ver ) { | ||
| if ( false === $ver ) { | ||
| $ver = wp_styles()->default_version; | ||
| } | ||
| $preload = add_query_arg( 'ver', $ver, $preload ); | ||
| } |
There was a problem hiding this comment.
When the version of the stylesheet is not define then we didn't get theme version. ex. wp_enqueue_style( 'style', get_stylesheet_uri(), array(), '' );
| * @since n.e.x.t | ||
| */ | ||
| function perflab_tseh_reset_stylesheet_check() { | ||
| delete_option( 'perflab_preload_stylesheet' ); |
There was a problem hiding this comment.
Please make sure to delete the new option in uninstall.php.
| // Bail if not a frontend request. | ||
| if ( is_admin() || defined( 'XMLRPC_REQUEST' ) || defined( 'REST_REQUEST' ) || defined( 'MS_FILES_REQUEST' ) ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Similar conditions are checked in perflab_tseh_send_early_hints_header(). Add a new function and use it.
| } | ||
| ); | ||
| } | ||
| add_action( 'plugins_loaded', 'perflab_hieh_send_early_hints_header' ); |
There was a problem hiding this comment.
Do we really need all this logic if we can just check the current post thumbnail ID and preload that image if it is available? If there is no thumbnail for the post, then I think we should preload nothing because the first image in the content is not always the hero image. Furthermore, the first image in the content can be far below the fold and in this case preloading it is inefficient. 🤔
There was a problem hiding this comment.
@eugene-manuilov What you're saying about the first content image can certainly happen, though at the same time it even applies to the featured image, it entirely depends on the theme where that is displayed. It usually is in the header area but not always.
Each of these concerns already apply to the fetchpriority="high" and loading="lazy" features too to be fair.
|
@mukeshpanchal27 @eugene-manuilov Thank you for the feedback. Just to highlight, this PR is not meant to be merged. It's fine to review it, but there's a couple things in here that I just quickly hacked together and that would certainly not be a proper approach if we wanted to truly make this a module. Just as some context; I'll probably eventually close this, not really worth too much polishing (unless something is broken that even affects the lab tests we're running with this code). |
This comment was marked as spam.
This comment was marked as spam.
5 participants
Summary
This is an experiment. Do not merge.
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.