IDE-4864: acli pull db db connector changes#1985
IDE-4864: acli pull db db connector changes#1985kalindi-adhiya wants to merge 8 commits intoacquia:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates IDE/ACLI site-instance database handling to fetch connection details via the updated Acquia Cloud API SDK, ensuring database pulls use the correct host/user/password (and ssh host) source.
Changes:
- Bump
typhonius/acquia-php-sdk-v2to^3.8.0. - Update
EnvironmentTransformer::transformSiteInstanceDatabase()to take both database metadata and database connection details. - Update
CommandBase::determineCloudDatabases()to fetch and use the new site-instance database connection details.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/Transformer/EnvironmentTransformer.php | Switches site-instance DB transformation to use a dedicated connection response for credentials/hosts. |
| src/Command/CommandBase.php | Fetches site-instance DB connection details and passes them into the updated transformer. |
| composer.json | Bumps Acquia Cloud API SDK dependency to ^3.8.0. |
| composer.lock | Locks updated SDK version and associated metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
============================================
+ Coverage 92.35% 92.40% +0.05%
- Complexity 1953 1956 +3
============================================
Files 123 123
Lines 7168 7178 +10
============================================
+ Hits 6620 6633 +13
+ Misses 548 545 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1985/acli.phar |
deepakmishra2
left a comment
There was a problem hiding this comment.
Solid work with good test coverage. The short-circuit optimization is worth addressing before merge — it avoids an unnecessary network call on the failure path.
3035e10 to
fa59b95
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Motivation
Fixes acli pull:db for ide meo
Proposed changes
Now there is 2 separate api calls required to have db information , implemented that change
testing on Ide
Testing steps
./bin/acli ckc