Fixed misleading comments on csp.py#1211
Open
cmaraziaris wants to merge 1 commit intoaimacode:masterfrom
Open
Conversation
Changed AC3 comments suggesting that: **If AC3 returns True, the CSP instance is Satisfiable.** However, that is not true in the general case, as also suggested in Wikipedia (https://en.wikipedia.org/wiki/Local_consistency#Consistency_and_satisfiability) and also in the textbook, under figure 6.3, suggesting that AC3 might be *powerless* at some specific unsatisfiable (Map Coloring) instances.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed AC3 comments previously suggesting that: If AC3 returns True, the CSP instance is Satisfiable.
However, that is not true in the general case, as suggested in Wikipedia and also in the textbook, under figure 6.3, suggesting that AC3 might be powerless at some specific unsatisfiable (Map Coloring) instances.