Skip to content

MI-315: Upgrade gadget deployment pipeline#128

Merged
kai-nguyen-aligent merged 4 commits intomainfrom
feat/MI-315-gadget-deployment-update
Apr 16, 2026
Merged

MI-315: Upgrade gadget deployment pipeline#128
kai-nguyen-aligent merged 4 commits intomainfrom
feat/MI-315-gadget-deployment-update

Conversation

@kai-nguyen-aligent
Copy link
Copy Markdown
Contributor

Description of the proposed changes

  • Replaced push-staging and deploy-production boolean inputs with a single action input — callers must now pass action: push or action: deploy instead of setting separate booleans.
  • environment-name is no longer defaulted to "staging" — it is now optional overall but required when action: push, with a runtime validation step that fails fast if missing.
  • Temporary environment strategy for production deploys — when action: deploy, the workflow automatically:
    • Creates a temporary Gadget environment (deploy-<run_id>)
    • Pushes the checked-out code to it
    • Promotes (deploys) to production
    • Cleans up the temporary environment (runs even on failure)
      This ensures only the exact code from the Git ref is promoted, avoiding unreviewed changes in shared staging.

Notes to reviewers

ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

@kai-nguyen-aligent kai-nguyen-aligent requested a review from a team as a code owner April 13, 2026 04:10
@kai-nguyen-aligent kai-nguyen-aligent changed the title MI-315 Upgrade gadget deployment pipeline MI-315: Upgrade gadget deployment pipeline Apr 13, 2026
Comment thread .github/workflows/gadget-deploy.yml
Comment thread .github/workflows/gadget-deploy.yml
Comment thread .github/workflows/gadget-deploy.yml
Comment thread .github/workflows/gadget-deploy.yml Outdated
@kai-nguyen-aligent
Copy link
Copy Markdown
Contributor Author

Thanks, @TheOrangePuff I addressed the check for action in test step and add my comment/opinion for others. Could you please check and let me know your thought.

TheOrangePuff
TheOrangePuff previously approved these changes Apr 16, 2026
Copy link
Copy Markdown
Member

@TheOrangePuff TheOrangePuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kai-nguyen-aligent kai-nguyen-aligent merged commit 44a1427 into main Apr 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants