MI-315: Upgrade gadget deployment pipeline#128
Merged
kai-nguyen-aligent merged 4 commits intomainfrom Apr 16, 2026
Merged
Conversation
TheOrangePuff
requested changes
Apr 15, 2026
Contributor
Author
|
Thanks, @TheOrangePuff I addressed the check for action in test step and add my comment/opinion for others. Could you please check and let me know your thought. |
…315-gadget-deployment-update
AdamJHall
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
push-staginganddeploy-productionboolean inputs with a single action input — callers must now passaction: pushoraction: deployinstead of setting separate booleans.environment-nameis no longer defaulted to "staging" — it is now optional overall but required when action: push, with a runtime validation step that fails fast if missing.This ensures only the exact code from the Git ref is promoted, avoiding unreviewed changes in shared staging.
Notes to reviewers
ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback