Fix redirect loop when stale root-path _token cookie exists from older Airflow instance#64955
Open
wolfdn wants to merge 1 commit intoapache:mainfrom
Open
Conversation
…der Airflow instance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
This PR fixes a bug that was introduced by this PR: #62771
When multiple Airflow instances are hosted on the same domain under different subpaths
(e.g.
/team-a/airflow/,/team-b/airflow/), users who previously visited an olderAirflow instance end up in an infinite redirect loop on the newer instance.
The older instance sets the
_tokencookie atPath=/. The newer instance scopes itscookie to the subpath (e.g.
Path=/team-a/airflow/). When the browser sends both cookies,the
JWTRefreshMiddlewaredetects the stale root-path token as invalid and clears it —but only at the subpath. The root-path cookie is never removed, so it keeps being sent on
every subsequent request:
Solution
When the middleware or the logout endpoint clears the
_tokencookie and the configuredcookie path is not
/, also delete the cookie atPath=/. This removes the staleroot-path cookie on the very first failed validation, breaking the loop immediately.
Changes
airflow-core/src/airflow/api_fastapi/auth/middlewares/refresh_token.py-When invalidating an expired/invalid token, also
delete_cookieatPath=/airflow-core/src/airflow/api_fastapi/core_api/routes/public/auth.py-On logout, also
delete_cookieatPath=/Was generative AI tooling used to co-author this PR?
GitHub Copilot - Claude Opus 4.6
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.