fix overflow in allocation size calculation in apreq_param_make#636
Open
jmestwa-coder wants to merge 1 commit intoapache:trunkfrom
Open
fix overflow in allocation size calculation in apreq_param_make#636jmestwa-coder wants to merge 1 commit intoapache:trunkfrom
jmestwa-coder wants to merge 1 commit intoapache:trunkfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix integer overflow in
apreq_param_make()when computing the allocation size.Root Cause
The allocation size was calculated using unchecked arithmetic:
For sufficiently large values, this addition can overflow
apr_size_t, leading to an incorrect (wrapped) allocation size.Fix
Add bounds checks before performing the allocation:
nlen + vlendoes not overflowapr_size_tBehavior
NULL(already handled by callers)Impact
Ensures allocation size calculations are safe and do not rely on implicit assumptions about input sizes.