fix(docker): skip partition wait for standalone rocksdb mode#3000
Open
fix(docker): skip partition wait for standalone rocksdb mode#3000
Conversation
The `wait-partition.sh` script was called unconditionally in `docker-entrypoint.sh`, causing standalone containers (rocksdb backend) to hang for 120s printing "Waiting for partition assignment..." since there is no Store service to respond. Now reads the actual backend from `hugegraph.properties` and only runs the partition wait when `backend=hstore`.
dosubot
bot
added
the
size:S
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the HugeGraph Docker entrypoint so the post-start “partition wait” logic only runs in distributed hstore mode, preventing unnecessary 120s startup delays in standalone rocksdb containers (Fixes #2999).
Changes:
- Detects the configured backend from
conf/graphs/hugegraph.propertiesat runtime. - Runs
wait-partition.sh(and setsSTORE_REST) only whenbackend=hstore. - Avoids polling
http://store:8520in standalone rocksdb mode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Replace \s with [[:space:]] for consistency with set_prop() in the same file - Add head -n 1 to prevent multi-line matches - Add || true to prevent pipefail exit when backend key is missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2999
hugegraph-server/Dockerfile, defaultrocksdbbackend) gets stuck printingWaiting for partition assignment...for 120s after startupwait-partition.shwas called unconditionally indocker-entrypoint.sh— it pollshttp://store:8520which only exists in distributedhstoremodebackendvalue fromhugegraph.propertiesand only runwait-partition.shwhenbackend=hstoreTest plan
/versions,/graphs)