[ty] Support **{...} unpacking in TypedDict constructors#24523
Draft
charliermarsh wants to merge 1 commit intocharlie/td-duplicatefrom
Draft
[ty] Support **{...} unpacking in TypedDict constructors#24523charliermarsh wants to merge 1 commit intocharlie/td-duplicatefrom
**{...} unpacking in TypedDict constructors#24523charliermarsh wants to merge 1 commit intocharlie/td-duplicatefrom
Conversation
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 87.72%. The percentage of expected errors that received a diagnostic held steady at 82.85%. The number of fully passing files held steady at 74/132. |
Memory usage reportMemory usage unchanged ✅ |
|
| Lint rule | Added | Removed | Changed |
|---|---|---|---|
invalid-await |
40 | 0 | 0 |
missing-typed-dict-key |
0 | 6 | 0 |
invalid-key |
1 | 0 | 0 |
invalid-return-type |
1 | 0 | 0 |
| Total | 42 | 6 | 0 |
Changes in flaky projects detected. Raw diff output excludes flaky projects; see the HTML report for details.
Raw diff:
cwltool (https://github.com/common-workflow-language/cwltool)
- tests/test_pathmapper.py:95:15 error[missing-typed-dict-key] Missing required key 'class' in TypedDict `CWLFileType` constructor
- cwltool/command_line_tool.py:714:25 error[missing-typed-dict-key] Missing required key 'class' in TypedDict `CWLFileType` constructor
+ cwltool/command_line_tool.py:719:25 error[invalid-key] Unknown key "writable" for TypedDict `CWLFileType`
- cwltool/main.py:595:12 error[missing-typed-dict-key] Missing required key 'class' in TypedDict `CWLFileType` constructor
- cwltool/process.py:1153:20 error[missing-typed-dict-key] Missing required key 'class' in TypedDict `CWLDirectoryType` constructor
- cwltool/utils.py:304:19 error[missing-typed-dict-key] Missing required key 'class' in TypedDict `CWLDirectoryType` constructor
- cwltool/utils.py:315:28 error[missing-typed-dict-key] Missing required key 'class' in TypedDict `CWLFileType` constructor
charliermarsh
force-pushed
the
charlie/td-unpack
branch
from
afe37c9 to
128de59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.