Fix/modelbuilder deploy datacacheconfig 5750#5764
Open
aviruthen wants to merge 12 commits intoaws:masterfrom
Open
Fix/modelbuilder deploy datacacheconfig 5750#5764aviruthen wants to merge 12 commits intoaws:masterfrom
aviruthen wants to merge 12 commits intoaws:masterfrom
Conversation
…eateInferenceCom (5750)
mollyheamazon
previously approved these changes
Apr 16, 2026
Collaborator
Author
|
sagemaker-core and sagemaker-rain integ tests should not be triggered, changes only made to sagemaker-serve module |
nargokul
reviewed
Apr 20, 2026
Comment on lines
+92
to
+94
| # Return immediately when endpoint is no longer creating. | ||
| # Log fetching below is best-effort and must not block completion. | ||
| return desc |
Contributor
There was a problem hiding this comment.
Log fetching below is best-effort and must not block completion.
What does this mean ?
Looks like desc will be returned for most cases and not when endpoint is no longer creating
Collaborator
Author
There was a problem hiding this comment.
I was running into issues where the endpoint reached a non-creating status but was not returning from monitoring deployment progress. This change is just meant to emphasize that the moment the endpoint is no longer creating we should return and immediately continue with ModelBuilder logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue requests exposing additional CreateInferenceComponent API parameters through ModelBuilder.deploy(), primarily DataCacheConfig, BaseInferenceComponentName, Container specification, and VariantName. The _deploy_core_endpoint method in model_builder.py builds InferenceComponentSpecification but does not pass through these parameters. The sagemaker.core.shapes module already has InferenceComponentDataCacheConfig and related shapes. The fix requires: (1) adding new optional parameters to the deploy() method and _deploy_core_endpoint(), (2) wiring those parameters into the InferenceComponentSpecification and InferenceComponent.create() call, and (3) making variant_name configurable instead of hardcoded to 'AllTraffic'. The deploy wrappers in model_builder_servers.py pass **kwargs through to _deploy_core_endpoint, so they require no changes.
Includes unit and integration tests.