Skip to content

Fix sagemaker_config bugs in ModelTrainer #5767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
admivsn wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −3
Open

Fix sagemaker_config bugs in ModelTrainer #5767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34f85f8
Fix Networking parameter name
admivsn Apr 16, 2026
f08349d
Fix security_group_ids
admivsn Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sagemaker-train/src/sagemaker/train/model_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ def _populate_intelligent_defaults_from_training_job_space(self):
if not self.networking:
if default_enable_network_isolation is not None or default_vpc_config is not None:
self.networking = Networking(
default_enable_network_isolation=default_enable_network_isolation,
enable_network_isolation=default_enable_network_isolation,
subnets=self.config_mgr.resolve_value_from_config(
config_path=TRAINING_JOB_SUBNETS_PATH
),
Expand All @@ -342,8 +342,8 @@ def _populate_intelligent_defaults_from_training_job_space(self):
config_path=TRAINING_JOB_SUBNETS_PATH
)
if self.networking.security_group_ids is None:
self.networking.subnets = self.config_mgr.resolve_value_from_config(
config_path=TRAINING_JOB_SUBNETS_PATH
self.networking.security_group_ids = self.config_mgr.resolve_value_from_config(
config_path=TRAINING_JOB_SECURITY_GROUP_IDS_PATH
)

if not self.output_data_config:
Expand Down
Loading