allow SAGEMAKER_HUB_NAME env var override for HUB_NAME constant#5784
Merged
mollyheamazon merged 2 commits intoaws:masterfrom Apr 21, 2026
Merged
allow SAGEMAKER_HUB_NAME env var override for HUB_NAME constant#5784mollyheamazon merged 2 commits intoaws:masterfrom
mollyheamazon merged 2 commits intoaws:masterfrom
Conversation
mollyheamazon
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mollyheamazon
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
nargokul
reviewed
Apr 21, 2026
Comment on lines
+11
to
+13
| from sagemaker.train import constants | ||
| importlib.reload(constants) | ||
| return constants.HUB_NAME |
Contributor
There was a problem hiding this comment.
Can we use a function get_sagemaker_hub_name instead of constants so its fetched on runtime ?
mollyheamazon
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mollyheamazon
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
mufaddal-rohawala
approved these changes
Apr 21, 2026
nargokul
approved these changes
Apr 21, 2026
Contributor
Author
|
Flaky test failures not related to the code change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Recipes and hub content for fine-tuning trainers (
SFTTrainer,DPOTrainer,RLVRTrainer,RLAIFTrainer) and evaluators (BenchMarkEvaluator,CustomScorerEvaluator) can only be exercised end-to-end after they ship tothe public JumpStart hub. This blocks PySDK developers from validating
recipe-dependent fixes until a JumpStart release, and prevents Studio's
private-hub E2E suite from targeting the PySDK trainer path.
Description
Internal-only change. No user-facing API change.
Switches the
HUB_NAMEconstant insagemaker.train.constantsto read fromthe
SAGEMAKER_HUB_NAMEenvironment variable, falling back to"SageMakerPublicHub"when unset:Intended consumers: PySDK developers validating recipe changes locally, and
Studio's private-hub E2E suite. Not intended as a public-facing configuration
knob — no docs or public API changes.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.