fix(serve): prevent code injection in capture_dependencies#5792
Open
zhaoqizqwang wants to merge 1 commit intoaws:masterfrom
Open
fix(serve): prevent code injection in capture_dependencies#5792zhaoqizqwang wants to merge 1 commit intoaws:masterfrom
zhaoqizqwang wants to merge 1 commit intoaws:masterfrom
Conversation
…polation
capture_dependencies built a `python -c` script by f-string interpolating
pkl_path and dest_path, both derived from a user-supplied model directory,
directly into Python source. A directory name containing `"` could break out
of the string literal and execute arbitrary Python via expression chaining
(e.g. `model" + __import__("os").system("...") + "`), giving an attacker
local code execution when a victim extracted a malicious tarball and passed
it to ModelBuilder with dependencies={"auto": True}.
Use the !r conversion so repr() emits properly escaped Python string
literals for both paths. Any embedded quotes, backslashes, or control
characters are escaped, so the paths arrive at get_requirements_for_pkl_file
as inert string constants rather than executable code.
Affects Linux/macOS; Windows was not exploitable because `"` is an invalid
filename character on NTFS. Reported via AWS Vulnerability Reporting Program
(P414309851, CWE-94).
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
zhaoqizqwang
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
jam-jee
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(serve): prevent code injection in capture_dependencies path interpolation
capture_dependencies built a
python -cscript by f-string interpolating pkl_path and dest_path, both derived from a user-supplied model directory, directly into Python source. A directory name containing"could break out of the string literal and execute arbitrary Python via expression chaining (e.g.model" + __import__("os").system("...") + "), giving an attacker local code execution when a victim extracted a malicious tarball and passed it to ModelBuilder with dependencies={"auto": True}.Use the !r conversion so repr() emits properly escaped Python string literals for both paths. Any embedded quotes, backslashes, or control characters are escaped, so the paths arrive at get_requirements_for_pkl_file as inert string constants rather than executable code.