Skip to content

Update to Python 3.10 and enhance type annotations#482

Open
hunterhogan wants to merge 6 commits intobastibe:masterfrom
hunterhogan:v310
Open

Update to Python 3.10 and enhance type annotations#482
hunterhogan wants to merge 6 commits intobastibe:masterfrom
hunterhogan:v310

Conversation

@hunterhogan
Copy link
Copy Markdown

Upgrade the codebase to be compatible with Python 3.10 and introduce type aliases and overloads for improved type hinting in methods.

hunterhogan and others added 6 commits April 17, 2026 13:47
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
@bastibe
Copy link
Copy Markdown
Owner

bastibe commented Apr 18, 2026

Stop spamming.

@bastibe bastibe closed this Apr 18, 2026
@hunterhogan
Copy link
Copy Markdown
Author

😞

I sincerely don't know what I did that is spamming. I am following the advice of other people about how to better organize a pull request and about typing. I want to know what mistake I made, so I can improve. I threw out the work I had previously done and started fresh because I wanted to make sure I did everything correctly. That's why it took me three hours of work to make this.

mgrinshpon/toolz-stubs#50 (comment)
fonttools/ufoLib2#423 (comment)
python/typeshed#15341 (review)
python/typeshed#15341 (comment)

I've been working on typing for soundfile for well over a year: it is in the initial commit of this stupid repo I made for stubs. I didn't about typeshed or how to ... hell, I basically didn't know how to find anything, do anything, or work with other people on anything. resampy was also in the initial commit to my stub repo. It's in typeshed now, despite the mountain of mistakes I made.

I'm sorry I spammed you, and I will adjust my actions if you tell me how to improve.

@bastibe bastibe reopened this Apr 19, 2026
@bastibe
Copy link
Copy Markdown
Owner

bastibe commented Apr 19, 2026

My apologies. Your messages read too much like AI slop, so I assumed the worst. But your response proves that was an error on my part, for which I am very sorry.

For what it's worth, I would prefer to iterate on a single pull request instead of starting new ones. Regardless, I've reopened the pull request. The tests still fail, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants