Skip to content

chore(pypi): remove unused config settings code#3739

Open
aignas wants to merge 4 commits intobazel-contrib:mainfrom
aignas:aignas.chore.cleanup-legacy-pip-code-2
Open

chore(pypi): remove unused config settings code#3739
aignas wants to merge 4 commits intobazel-contrib:mainfrom
aignas:aignas.chore.cleanup-legacy-pip-code-2

Conversation

@aignas
Copy link
Copy Markdown
Collaborator

@aignas aignas commented Apr 26, 2026

Summary:

  • Remove unused pip_* config settings since they have been no op for a while.
  • The code was experimental, so it is likely nobody relied heavily on those things.
  • Only leave the OSX version flag - we may want to rename that in the future.

Related #260.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request streamlines the pip integration by removing the enable_pipstar feature, experimental_target_platforms attribute, and legacy configuration flags, while migrating entry point generation to py_console_script_binary. Review feedback highlights dead code regarding the extras parameter in wheel_installer.py and suggests a more robust method for Python version detection in pip_repository.bzl.

Comment thread python/private/pypi/whl_installer/wheel_installer.py Outdated
Comment thread python/private/pypi/whl_installer/wheel_installer.py Outdated
Comment thread python/private/pypi/pip_repository.bzl Outdated
@aignas aignas force-pushed the aignas.chore.cleanup-legacy-pip-code-2 branch from 657d0db to 5f6fe90 Compare April 27, 2026 13:38
@aignas aignas marked this pull request as ready for review April 27, 2026 14:05
@aignas aignas requested a review from rickeylev as a code owner April 27, 2026 14:05
@rickeylev
Copy link
Copy Markdown
Collaborator

Remove unused pip_* config settings since they have been no op for a while.

These are unused? I thought the intent was to use them to allow dependency selection when requirement env markers can't do so. e.g., given requirements_musl.txt and requirements_glibc.txt, one would set --pip_lib=musl|glibc to pick between the two closures.

@aignas
Copy link
Copy Markdown
Collaborator Author

aignas commented Apr 27, 2026

Remove unused pip_* config settings since they have been no op for a while.

These are unused? I thought the intent was to use them to allow dependency selection when requirement env markers can't do so. e.g., given requirements_musl.txt and requirements_glibc.txt, one would set --pip_lib=musl|glibc to pick between the two closures.

This was like that initially, but in actuality, the musl selection has to be done through the platforms in the pip.default, because the requirements here need to be provided by the user, i.e. is it OK to fall back to glibc wheels, is it not?

By the way, these flags that I am removing here were for selecting the wheel based on the libc version that one may have on different systems, but modelling that is always really difficult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants