fix: Helm chart name#9
Open
chevvak2 wants to merge 24 commits intobiothings:mainfrom
Open
Conversation
- Updated Chart.yaml name from biothings-annotator to node-normalization - Fixed container name, port (8000), and image repository references - Updated all template functions to use node-normalization prefix - Fixed environment variable references and added PORT env var - Updated NCATS labels and hostname placeholders - Corrected template function calls in all Kubernetes manifests
✅ Combined changes: - Remote: Clean Docker structure, port consistency updates - Local: PyStow permissions fix, ES config.json, environment variables 🔧 Key fixes preserved: - Custom config.json with correct Elasticsearch host - PYSTOW_HOME environment variable setup - Port 8000 standardization across all components - Enhanced supervisord configuration Resolves NodeNormalization pod crash loop issues.
Add fullnameOverride to prevent deployment name from being: - OLD: biothings-annotator-node-normalization-xxx-xxx - NEW: node-normalization-xxx-xxx This overrides the default logic that combines Helm release name with chart name, ensuring clean pod names.
- Set OPENTELEMETRY_ENABLED: false in config.json - Resolves ModuleNotFoundError: No module named 'opentelemetry' - ES index validation now working after creating nodenorm index The pod should now start successfully without telemetry dependencies.
- Patch health.py to use keyword arguments for indices.get() call - Resolves TypeError with Elasticsearch client 8.19.3 - Enables /status endpoint to work properly for health checks
- Replace complex sed commands with clean patched health.py - Fixes both Elasticsearch API compatibility (8.x) and metadata access issues - Provides resilient health check that works without complex metadata dependencies - Uses default babel version fallback when metadata unavailable
- Update from biothings/NodeNormalizationAPI to chevvak2/NodeNormalizationAPI - Ensures Docker build uses the correct repository with our fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.