Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the Expo Updates support to
react-native-brownfieldAPIs and expo config plugin.iOS:
AppControllerinitialization during theapplicationDidFinishlaunchingWithOptions.AppController.shared.launchAssetURL- if it is availableReactNativeViewController- insideinit()- we do theAppController.startto start theStartupProcedurefor Expo Updates.init- which returns us whether theAppControllerstarted with success.The major dependency to allow Expo Updates is based on the patch added in this PR. Basically, Expo Updates account for being used in a greenfield App and even for brownfield app with integrated approach.
It does not account for usage in brownfield apps with isolated approach. Hence, the patch included in this PR, Now allows that approach to work as well. This patch needs to be upstreamed to Expo Updates package.
TODO:
Test plan
iOS - Apple App
Case: EXUpdatesCheckOnLaunch=NEVER
Never.mp4
Case: EXUpdatesCheckOnLaunch=ALWAYS
Always.mp4
Case: EXUpdatesCheckOnLaunch=NEVER + On demand Fetch
Never+Fetch.mp4