fix: mirror limits optional chaining#568
Merged
cameri merged 3 commits intocameri:mainfrom Apr 25, 2026
Merged
Conversation
…ror has no limits configured
There was a problem hiding this comment.
Pull request overview
Fixes a crash in StaticMirroringWorker.canAcceptEvent() when a static mirror entry omits the optional limits block, preventing mirrored events from being silently dropped.
Changes:
- Use optional chaining when reading
this.config.limits?.eventto safely handle missing mirror limits. - Add a patch changeset documenting the bug fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/app/static-mirroring-worker.ts |
Prevents TypeError when Mirror.limits is undefined by using optional chaining. |
.changeset/sunny-jars-try.md |
Adds a patch changeset entry for the static mirroring fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
🦋 Changeset detectedLatest commit: e44ca9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add optional chaining to
this.config.limits?.eventinStaticMirroringWorker.canAcceptEvent()Related Issue
Fixes #567
Motivation and Context
Mirror.limitsis typed as optional but was accessed without optional chaining. When a mirror entry has nolimitsblock configured, this throws a TypeError inside the message handler which gets swallowed by the surrounding try/catch. So the mirror connects and subscribes fine, but silently drops every incoming event.How Has This Been Tested?
Manually configured a mirror entry without a
limitsblock and confirmed events are stored correctly after the fix.Screenshots (if appropriate):
N/A
Types of changes
Checklist: