Skip to content

cfengine format: Refactored code, added type hints and docstrings, expanded tests, and fixed small issues #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olehermanse wants to merge 9 commits into
base: main
Choose a base branch
from
Open

cfengine format: Refactored code, added type hints and docstrings, expanded tests, and fixed small issues #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
214a218
format.py: Refactored using Claude Code
olehermanse Apr 9, 2026
d744105
format.py: Added docstrings and type hints
olehermanse Apr 9, 2026
3f34f17
tests: Expanded formatting unit tests
olehermanse Apr 9, 2026
f45f364
Fixed issues which came after merge
olehermanse Apr 10, 2026
09c8664
Fixed inconsistency between format json and format policy function
olehermanse Apr 13, 2026
6ed066f
cfengine format: Made sure trailing commas are always added when mult…
olehermanse Apr 13, 2026
63348d2
Adjusted formatting tests with more trailing comma cases
olehermanse Apr 13, 2026
88ff48d
Fixed trailing comma and closing curly brace issues
olehermanse Apr 13, 2026
804e204
Improved can_single_line_promise() with comments and asserts
olehermanse Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cfengine_cli/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def deploy() -> int:
return r


def _format_filename(filename, line_length, check):
def _format_filename(filename: str, line_length: int, check: bool) -> int:
if filename.startswith("./."):
return 0
if filename.endswith(".json"):
Expand All @@ -60,7 +60,7 @@ def _format_filename(filename, line_length, check):
raise UserError(f"Unrecognized file format: {filename}")


def _format_dirname(directory, line_length, check):
def _format_dirname(directory: str, line_length: int, check: bool) -> int:
ret = 0
for filename in find(directory, extension=".json"):
ret |= _format_filename(filename, line_length, check)
Expand Down
Loading
Loading