Skip to content

fix: honour -o json/custom across missing and broken commands#586

Open
alubbock wants to merge 6 commits intocivo:masterfrom
alubbock:fix/k8s-nodepool-instance-delete-json-output
Open

fix: honour -o json/custom across missing and broken commands#586
alubbock wants to merge 6 commits intocivo:masterfrom
alubbock:fix/k8s-nodepool-instance-delete-json-output

Conversation

@alubbock
Copy link
Copy Markdown

Several commands ignored the -o json and -o custom flags, always
printing plain text regardless. One command (kubernetes cluster remove)
had a latent bug where -o json also triggered the custom formatter.

Missing output format handling (always printed plain text):

  • kubernetes node-pool instance-delete
  • kubernetes cluster remove (also had WriteCustomOutput inside the
    "json" case, so -o json produced both outputs)
  • apikey remove / apikey set
  • instance public-ip / instance recovery
  • kubernetes update-kubeconfig
  • network show

Also fixed in instance recovery: a fmt.Println("Instance ID is: …") that fired before the API call, unconditionally, on every
invocation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant