OCSP: Use url.PathUnescape instead of url.QueryUnescape#771
Open
rolandshoemaker wants to merge 1 commit intocloudflare:masterfrom
Open
OCSP: Use url.PathUnescape instead of url.QueryUnescape#771rolandshoemaker wants to merge 1 commit intocloudflare:masterfrom
rolandshoemaker wants to merge 1 commit intocloudflare:masterfrom
Conversation
c20385b to
6b54a80
Compare
Contributor
Author
|
Blerp, didn't realize |
Contributor
|
I need to update the test suite a little bit to suit the 1.8. So I will try to re-run the test and merge this after the update. |
Contributor
Author
|
For what it's worth the main issue with tests seems to be that a number of the test certificates are malformed ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out there is already a method that handles the
'+' -> ' 'encoding issue so we don't have to do it manually.