Skip to content

OCSP: Use url.PathUnescape instead of url.QueryUnescape#771

Open
rolandshoemaker wants to merge 1 commit intocloudflare:masterfrom
rolandshoemaker:ocsp-path-unescape
Open

OCSP: Use url.PathUnescape instead of url.QueryUnescape#771
rolandshoemaker wants to merge 1 commit intocloudflare:masterfrom
rolandshoemaker:ocsp-path-unescape

Conversation

@rolandshoemaker
Copy link
Copy Markdown
Contributor

Turns out there is already a method that handles the '+' -> ' ' encoding issue so we don't have to do it manually.

@rolandshoemaker
Copy link
Copy Markdown
Contributor Author

Blerp, didn't realize url.PathUnescape was added in 1.8, unless we bump the minimum version this change is a no-go.

@lziest
Copy link
Copy Markdown
Contributor

lziest commented May 21, 2017

I need to update the test suite a little bit to suit the 1.8. So I will try to re-run the test and merge this after the update.

@rolandshoemaker
Copy link
Copy Markdown
Contributor Author

For what it's worth the main issue with tests seems to be that a number of the test certificates are malformed (x509: RSA key missing NULL parameters) and need to be renegerated to conform with the new stricter crypto/x509 parsing rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants