Open
Conversation
…/reactFlow/components/ReactFlowCanvas.tsx
This reverts commit 24586e8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a line as an edge that connects two "ghost nodes".
As an alternative, I went down the path of implementing this as a "custom node" (very rough): https://github.com/code-dot-org/code-dot-org/compare/ben/sketch2-line
I think implementing it as an edge makes sense longer term because we'll be able tap into the built-in goodness that React Flow includes for "lines" as part of its edge implementation.
Their docs (linked below) also mention the idea ("What about an “edge” not connected to any nodes at all?") of an edge with no nodes (ie, what we're trying to do), so that seems like a reasonable standard approach.
Links
Testing story
Tested manually (see video above).
Follow-up work