docs: fix Person._name init typo in 05_Object_model/02#198
Open
mvanhorn wants to merge 1 commit intodabeaz-course:masterfrom
Open
docs: fix Person._name init typo in 05_Object_model/02#198mvanhorn wants to merge 1 commit intodabeaz-course:masterfrom
mvanhorn wants to merge 1 commit intodabeaz-course:masterfrom
Conversation
The Private Attributes example initialized self._name to 0, which contradicted the REPL example two lines below where p._name read back as 'Guido' (the name passed into __init__). Initialize to name so the code and REPL output match. Fixes dabeaz-course#197
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #197
What changed
Notes/05_Object_model/02_Classes_encapsulation.mdintroduced_nameas a private attribute but initialized it to0:The REPL block directly below then shows:
That only works if
self._name = name. This PR changes the initializer to match the output shown in the same example.One-line docs diff.