Skip to content

arch: make deviceid moe felxible with cuda/rocm env vars#2906

Merged
mloubout merged 1 commit intomainfrom
tweak-deviceid
Apr 29, 2026
Merged

arch: make deviceid moe felxible with cuda/rocm env vars#2906
mloubout merged 1 commit intomainfrom
tweak-deviceid

Conversation

@mloubout
Copy link
Copy Markdown
Contributor

No description provided.

@mloubout mloubout added the arch jitting, archinfo, ... label Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.40%. Comparing base (6c41641) to head (bfeebc4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_gpu_common.py 11.11% 8 Missing ⚠️
devito/operator/operator.py 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2906   +/-   ##
=======================================
  Coverage   83.40%   83.40%           
=======================================
  Files         248      248           
  Lines       51625    51633    +8     
  Branches     4454     4457    +3     
=======================================
+ Hits        43056    43064    +8     
+ Misses       7815     7814    -1     
- Partials      754      755    +1     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.68% <25.00%> (-0.02%) ⬇️
pytest-gpu-gcc- 78.00% <0.00%> (-0.03%) ⬇️
pytest-gpu-icx- 77.64% <0.00%> (+0.01%) ⬆️
pytest-gpu-nvc-nvidiaX 69.22% <25.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mloubout mloubout force-pushed the tweak-deviceid branch 2 times, most recently from 891ccb4 to 5a91eec Compare April 28, 2026 21:57
Copy link
Copy Markdown
Contributor

@EdCaunt EdCaunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable - I would also update the FAQ to document this behaviour

@mloubout mloubout merged commit 8209107 into main Apr 29, 2026
42 checks passed
@mloubout mloubout deleted the tweak-deviceid branch April 29, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch jitting, archinfo, ...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants