Conversation
Previously ThreadbareProjectSettings extended EditorPlugin, which means it is not available in release builds. As a result any code which accessed ThreadbareProjectSettings did not work. This includes the splash screen, main menu, and (transitively) the story book. Extend Node instead, and move the actual plugin piece to a separate script. Also fix an excessive use of the letter 't' in the word 'setttings'. Resolves #2138
Member
Author
|
(Found while testing #2134.) |
|
Play this branch at https://play.threadbare.game/branches/endlessm/wjt/fix-accessing-threadbare-project-settings-in-non-editor-builds/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
manuq
approved these changes
Apr 21, 2026
| const SKIP_SPLASH = "threadbare/debugging/skip_splash" | ||
|
|
||
| static var setttings_configuration = { | ||
| static var settings_configuration = { |
Collaborator
|
"an excessive use of the letter 't' " 💯 |
manuq
deleted the
wjt/fix-accessing-threadbare-project-settings-in-non-editor-builds
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously ThreadbareProjectSettings extended EditorPlugin, which means
it is not available in release builds. As a result any code which
accessed ThreadbareProjectSettings did not work. This includes the
splash screen, main menu, and (transitively) the story book.
Extend Node instead, and move the actual plugin piece to a separate
script. Also fix an excessive use of the letter 't' in the word
'setttings'.
Resolves #2138