feat(perforce,SCM): Remove beta flag, document on-demand source context fetching#17498
feat(perforce,SCM): Remove beta flag, document on-demand source context fetching#17498
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
bruno-garcia
left a comment
bruno-garcia
left a comment
There was a problem hiding this comment.
Approving to unblock but IMO we should reconsider where this setting lives before we move ahead
| @@ -0,0 +1,59 @@ | |||
| --- | |||
| title: SCM Source Context | |||
There was a problem hiding this comment.
How about being more explicit about it:
| title: SCM Source Context | |
| title: SCM Source Context Fetching |
|
|
||
| Source context fetching is opt-in per project. To enable it: | ||
|
|
||
| 1. In [sentry.io](https://sentry.io), go to **Settings > Projects > [your project] > General Settings**. |
There was a problem hiding this comment.
We should have some settings redirect URL we can use here to have a link take users directly to that page
| Source context fetching is opt-in per project. To enable it: | ||
|
|
||
| 1. In [sentry.io](https://sentry.io), go to **Settings > Projects > [your project] > General Settings**. | ||
| 2. Under **Client Security**, turn on **Enable SCM Source Context**. |
There was a problem hiding this comment.
I realize this was added here because we have the sourcemap fetching here. But I wonder if it should live under the SCM provider settings instead? "Client Security" Isn't where I'd think to find this.
In the case of sourcemaps it makes sense since anyone could send an event to Sentry that indicates where to fetch the sourcemaps from. But in the case of SCM source context, you read this from the Sentry integration settings, so a malicious actor can't influence where we fetch from.
There was a problem hiding this comment.
exactly my thoughts when I was looking to enable it 💯 Naturally I was going to Org Settings > Integrations > GitHub > Settings
|
|
||
| ## Features | ||
|
|
||
| - [SCM Source Context](/integrations/source-code-mgmt/source-context/) — render source lines around each stack-trace frame on demand from your SCM, for events that don't carry inline source context. |
There was a problem hiding this comment.
| - [SCM Source Context](/integrations/source-code-mgmt/source-context/) — render source lines around each stack-trace frame on demand from your SCM, for events that don't carry inline source context. | |
| - [SCM Source Context](/integrations/source-code-mgmt/source-context/) — render source lines around each stack-trace frame on demand from your SCM provider, for events that don't carry inline source context. |
|
|
||
| The toggle requires `project:write` permission. | ||
|
|
||
| ## How It Works |
There was a problem hiding this comment.
Would be great to have an image illustrating source context and highlighting the arrow on the right side . I've got this one, not sure if you wanna use it:
3 participants
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: