Skip to content

feat(sentry-types): Add metric protocol envelope support#1022

Open
szokeasaurusrex wants to merge 1 commit intoszokeasaurusrex/metrics-unitsfrom
szokeasaurusrex/metrics-protocol
Open

feat(sentry-types): Add metric protocol envelope support#1022
szokeasaurusrex wants to merge 1 commit intoszokeasaurusrex/metrics-unitsfrom
szokeasaurusrex/metrics-protocol

Conversation

@szokeasaurusrex
Copy link
Copy Markdown
Member

@szokeasaurusrex szokeasaurusrex commented Mar 2, 2026 •
edited
Loading

Add Metric protocol types and trace_metric envelope container serialization/deserialization in sentry-types.

Stacked on #1072

Closes #1008
Closes RUST-159

@linear
Copy link
Copy Markdown

linear Bot commented Mar 2, 2026

RUST-159 Add trace metric protocol models and envelope item container support

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 2, 2026 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 6226099

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch 2 times, most recently from ee23bf8 to 52b0419 Compare March 2, 2026 17:16
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review March 2, 2026 17:16
@szokeasaurusrex szokeasaurusrex requested a review from lcian as a code owner March 2, 2026 17:16
cursor[bot]

This comment was marked as resolved.

Sign in to view

lcian
lcian reviewed Mar 2, 2026
View reviewed changes
Comment thread sentry-types/src/protocol/v7.rs Outdated
lcian
lcian reviewed Mar 2, 2026
View reviewed changes
Comment thread sentry-types/src/protocol/v7.rs
lcian
lcian reviewed Mar 2, 2026
View reviewed changes
Comment thread sentry-types/src/protocol/v7.rs Outdated
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch from a5a8201 to d53c02f Compare March 4, 2026 14:13
szokeasaurusrex added a commit that referenced this pull request Mar 4, 2026
@szokeasaurusrex @jjbayer @lcian
feat(sentry-types): Add trace metric protocol envelope support (#1022)
d06efa0 
Add `TraceMetric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch from d53c02f to d06efa0 Compare March 4, 2026 14:14
@szokeasaurusrex szokeasaurusrex requested a review from lcian March 4, 2026 14:14
lcian
lcian approved these changes Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

lcian
lcian requested changes Mar 9, 2026
View reviewed changes
Comment thread sentry-types/src/protocol/v7.rs Outdated
Comment thread sentry-types/src/protocol/v7.rs Outdated
szokeasaurusrex added a commit that referenced this pull request Mar 10, 2026
@szokeasaurusrex @jjbayer @lcian
feat(sentry-types): Add metric protocol envelope support (#1022)
670c069 
Add `Metric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch from d06efa0 to 670c069 Compare March 10, 2026 12:50
@szokeasaurusrex szokeasaurusrex changed the title feat(sentry-types): Add trace metric protocol envelope support feat(sentry-types): Add metric protocol envelope support (#1022) Mar 10, 2026
@szokeasaurusrex szokeasaurusrex changed the title feat(sentry-types): Add metric protocol envelope support (#1022) feat(sentry-types): Add metric protocol envelope support Mar 10, 2026
@szokeasaurusrex szokeasaurusrex requested a review from lcian March 10, 2026 12:51
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch from 670c069 to da1a44c Compare March 10, 2026 14:40
szokeasaurusrex added a commit that referenced this pull request Mar 10, 2026
@szokeasaurusrex @jjbayer @lcian
feat(sentry-types): Add metric protocol envelope support (#1022)
da1a44c 
Add `Metric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
cursor[bot]

This comment was marked as resolved.

Sign in to view

szokeasaurusrex added a commit that referenced this pull request Mar 10, 2026
@szokeasaurusrex @jjbayer @lcian
feat(sentry-types): Add metric protocol envelope support (#1022)
d6d3ba8 
Add `Metric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch from da1a44c to d6d3ba8 Compare March 10, 2026 14:44
lcian
lcian approved these changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

szokeasaurusrex added a commit that referenced this pull request Mar 18, 2026
@szokeasaurusrex @jjbayer @lcian
feat(sentry-types): Add trace metric protocol envelope support (#1022)
8ecfda0 
Add `TraceMetric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
szokeasaurusrex added a commit that referenced this pull request Mar 31, 2026
@szokeasaurusrex @jjbayer @lcian
feat(sentry-types): Add metric protocol envelope support (#1022)
d4440fb 
Add `Metric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
szokeasaurusrex added a commit that referenced this pull request Apr 13, 2026
@szokeasaurusrex @jjbayer @lcian
feat(sentry-types): Add metric protocol envelope support (#1022)
82f2137 
Add `Metric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
szokeasaurusrex added a commit that referenced this pull request Apr 21, 2026
@szokeasaurusrex @jjbayer @lcian
feat(sentry-types): Add metric protocol envelope support (#1022)
a1b4721 
Add `Metric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch from 82f2137 to a1b4721 Compare April 21, 2026 12:40
@szokeasaurusrex szokeasaurusrex changed the base branch from master to szokeasaurusrex/metrics-units April 21, 2026 12:41
@szokeasaurusrex szokeasaurusrex marked this pull request as draft April 21, 2026 12:41
szokeasaurusrex added a commit that referenced this pull request Apr 21, 2026
@szokeasaurusrex @jjbayer @lcian
feat(sentry-types): Add metric protocol envelope support (#1022)
240a5b4 
Add `Metric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch from a1b4721 to 240a5b4 Compare April 21, 2026 12:43
szokeasaurusrex added a commit that referenced this pull request Apr 21, 2026
@szokeasaurusrex @jjbayer @lcian
feat(sentry-types): Add metric protocol envelope support (#1022)
870d354 
Add `Metric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch from 240a5b4 to 870d354 Compare April 21, 2026 12:44
sentry[bot]
sentry Bot reviewed Apr 21, 2026
View reviewed changes
Comment thread sentry-types/src/protocol/v7.rs
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review April 21, 2026 12:47
@szokeasaurusrex szokeasaurusrex requested a review from lcian April 21, 2026 12:47
@szokeasaurusrex
Copy link
Copy Markdown
Member Author

szokeasaurusrex commented Apr 21, 2026

Hey @lcian, I restacked this PR on top of #1072, and changed the type of unit accordingly to Option<Unit>. What do you think?

Also tagging you @giortzisg in case you would like to review (but it is okay if you skip this one).

lcian
lcian reviewed Apr 21, 2026
View reviewed changes
Comment thread force-push-refs.zsh Outdated
szokeasaurusrex added a commit that referenced this pull request Apr 21, 2026
@szokeasaurusrex @jjbayer @lcian
feat(sentry-types): Add metric protocol envelope support (#1022)
ee8296f 
Add `Metric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch from 870d354 to ee8296f Compare April 21, 2026 15:17
lcian
lcian approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-units branch from e92d0c8 to 75ee89b Compare April 22, 2026 09:14
@szokeasaurusrex @jjbayer @lcian
feat(sentry-types): Add metric protocol envelope support (#1022)
6226099 
Add `Metric` protocol types and `trace_metric` envelope container serialization/deserialization in `sentry-types`.

Closes #1008
Closes [RUST-159](https://linear.app/getsentry/issue/RUST-159/add-trace-metric-protocol-models-and-envelope-item-container-support)

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
Co-authored-by: Lorenzo Cian <17258265+lcian@users.noreply.github.com>
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/metrics-protocol branch from ee8296f to 6226099 Compare April 22, 2026 09:27
@szokeasaurusrex szokeasaurusrex mentioned this pull request Apr 22, 2026
Open
szokeasaurusrex added a commit that referenced this pull request Apr 22, 2026
@szokeasaurusrex
feat(metrics): Basic metrics capturing functionality in sentry-core (#…
06aeb9d 
…1073)

Basic metrics capture functionality. Follow-up PR will implement the rest.

Stacked on #1022

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>

Closes #1023
Closes [RUST-168](https://linear.app/getsentry/issue/RUST-168/implement-trace-metric-capture-and-batching-in-sentry-core)
Closes #1058
Closes [RUST-186](https://linear.app/getsentry/issue/RUST-186/add-trace-metric-tracing-association-in-sentry-core)
szokeasaurusrex added a commit that referenced this pull request Apr 22, 2026
@szokeasaurusrex
feat(metrics): Basic metrics capturing functionality in sentry-core (#…
cf4fe98 
…1073)

Basic metrics capture functionality. Follow-up PR will implement the rest.

Stacked on #1022

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>

Closes #1023
Closes [RUST-168](https://linear.app/getsentry/issue/RUST-168/implement-trace-metric-capture-and-batching-in-sentry-core)
Closes #1058
Closes [RUST-186](https://linear.app/getsentry/issue/RUST-186/add-trace-metric-tracing-association-in-sentry-core)
szokeasaurusrex added a commit that referenced this pull request Apr 22, 2026
@szokeasaurusrex
feat(metrics): Basic metrics capturing functionality in sentry-core (#…
f27b842 
…1073)

Basic metrics capture functionality. Follow-up PR will implement the rest.

Stacked on #1022

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>

Closes #1023
Closes [RUST-168](https://linear.app/getsentry/issue/RUST-168/implement-trace-metric-capture-and-batching-in-sentry-core)
Closes #1058
Closes [RUST-186](https://linear.app/getsentry/issue/RUST-186/add-trace-metric-tracing-association-in-sentry-core)
szokeasaurusrex added a commit that referenced this pull request Apr 22, 2026
@szokeasaurusrex
feat(metrics): Basic metrics capturing functionality in sentry-core (#…
93692bd 
…1073)

Basic metrics capture functionality. Follow-up PR will implement the rest.

Stacked on #1022

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>

Closes #1023
Closes [RUST-168](https://linear.app/getsentry/issue/RUST-168/implement-trace-metric-capture-and-batching-in-sentry-core)
Closes #1058
Closes [RUST-186](https://linear.app/getsentry/issue/RUST-186/add-trace-metric-tracing-association-in-sentry-core)
szokeasaurusrex added a commit that referenced this pull request Apr 23, 2026
@szokeasaurusrex
feat(metrics): Basic metrics capturing functionality in sentry-core (#…
cd20001 
…1073)

Basic metrics capture functionality. Follow-up PR will implement the rest.

Stacked on #1022

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>

Closes #1023
Closes [RUST-168](https://linear.app/getsentry/issue/RUST-168/implement-trace-metric-capture-and-batching-in-sentry-core)
Closes #1058
Closes [RUST-186](https://linear.app/getsentry/issue/RUST-186/add-trace-metric-tracing-association-in-sentry-core)
szokeasaurusrex added a commit that referenced this pull request Apr 23, 2026
@szokeasaurusrex
feat(metrics): Basic metrics capturing functionality in sentry-core (#…
d383c6c 
…1073)

Basic metrics capture functionality. Follow-up PR will implement the rest.

Stacked on #1022

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>

Closes #1023
Closes [RUST-168](https://linear.app/getsentry/issue/RUST-168/implement-trace-metric-capture-and-batching-in-sentry-core)
Closes #1058
Closes [RUST-186](https://linear.app/getsentry/issue/RUST-186/add-trace-metric-tracing-association-in-sentry-core)
szokeasaurusrex added a commit that referenced this pull request Apr 23, 2026
@szokeasaurusrex
feat(metrics): Basic metrics capturing functionality in sentry-core (#…
07acfeb 
…1073)

Basic metrics capture functionality. Follow-up PR will implement the rest.

Stacked on #1022

Co-authored-by: Joris Bayer <joris.bayer@sentry.io>

Closes #1023
Closes [RUST-168](https://linear.app/getsentry/issue/RUST-168/implement-trace-metric-capture-and-batching-in-sentry-core)
Closes #1058
Closes [RUST-186](https://linear.app/getsentry/issue/RUST-186/add-trace-metric-tracing-association-in-sentry-core)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentry sentry[bot] sentry[bot] left review comments

@cursor cursor[bot] cursor[bot] left review comments

@lcian lcian lcian approved these changes

@giortzisg giortzisg giortzisg approved these changes

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add trace metric protocol models and envelope item container support

3 participants

@szokeasaurusrex @lcian @giortzisg