Skip to content

Java: fix bug in partial path traversal #21734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owen-mc wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Java: fix bug in partial path traversal #21734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dca7046
Make inline expectation comments specify query
owen-mc Apr 18, 2026
63d20a5
Use inline expectations with second test
owen-mc Apr 18, 2026
6099c5d
Add SPURIOUS test for `+= File.separator`
owen-mc Apr 18, 2026
6d4a397
Fix bug so `+= File.separator` is recognized
owen-mc Apr 18, 2026
c6f641e
Add change note
owen-mc Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions java/ql/lib/change-notes/2026-04-18-partial-path-traversal-fix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The `java/partial-path-traversal` and `java/partial-path-traversal-from-remote` queries now correctly recognize file separator appends using `+=`.
7 changes: 5 additions & 2 deletions java/ql/lib/semmle/code/java/security/PartialPathTraversal.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,11 @@ private class CharacterLiteralFileSeparatorExpr extends FileSeparatorExpr, Chara
CharacterLiteralFileSeparatorExpr() { this.getValue() = "/" or this.getValue() = "\\" }
}

private class FileSeparatorAppend extends AddExpr {
FileSeparatorAppend() { this.getRightOperand() instanceof FileSeparatorExpr }
private class FileSeparatorAppend extends BinaryExpr {
FileSeparatorAppend() {
this.(AddExpr).getRightOperand() instanceof FileSeparatorExpr or
this.(AssignAddExpr).getRightOperand() instanceof FileSeparatorExpr
}
}

private predicate isSafe(Expr expr) {
Expand Down
5 changes: 4 additions & 1 deletion java/ql/test/query-tests/security/CWE-023/semmle/tests/PartialPathTraversal.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
Security/CWE/CWE-023/PartialPathTraversal.ql
query: Security/CWE/CWE-023/PartialPathTraversal.ql
postprocess:
- utils/test/PrettyPrintModels.ql
- utils/test/InlineExpectationsTestQuery.ql
Loading
Loading