Skip to content

Test feat bigframes#16714

Closed
ohmayr wants to merge 10 commits intomainfrom
test-feat-bigframes
Closed

Test feat bigframes#16714
ohmayr wants to merge 10 commits intomainfrom
test-feat-bigframes

Conversation

@ohmayr
Copy link
Copy Markdown
Contributor

@ohmayr ohmayr commented Apr 17, 2026

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables doctests for the bigframes package by removing a temporary skip in the Nox configuration and introducing a new shell script to manage doctest execution. The Kokoro configuration was updated to use a new project ID and point to this script. Additionally, some system tests were updated to ignore data type checks during series comparisons. Feedback was provided regarding a hardcoded project ID in the new script that overrides the configuration settings.

export GOOGLE_APPLICATION_CREDENTIALS="${KOKORO_GFILE_DIR}/service-account.json"
fi

export GOOGLE_CLOUD_PROJECT="bigframes-testing"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The GOOGLE_CLOUD_PROJECT is hardcoded to bigframes-testing, which overrides the value set in the Kokoro configuration file (.kokoro/presubmit/presubmit-doctest-bigframes.cfg). This makes the configuration change to precise-truck-742 ineffective. It is recommended to use a conditional assignment to allow the configuration to control the project ID while providing a sensible default.

Suggested change
export GOOGLE_CLOUD_PROJECT="bigframes-testing"
export GOOGLE_CLOUD_PROJECT="${GOOGLE_CLOUD_PROJECT:-bigframes-testing}"

@ohmayr ohmayr closed this Apr 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants