Conversation
…in run_doctest.sh
There was a problem hiding this comment.
Code Review
This pull request re-enables doctests for the bigframes package by removing a temporary skip in the Nox configuration and introducing a new shell script to manage doctest execution. The Kokoro configuration was updated to use a new project ID and point to this script. Additionally, some system tests were updated to ignore data type checks during series comparisons. Feedback was provided regarding a hardcoded project ID in the new script that overrides the configuration settings.
| export GOOGLE_APPLICATION_CREDENTIALS="${KOKORO_GFILE_DIR}/service-account.json" | ||
| fi | ||
|
|
||
| export GOOGLE_CLOUD_PROJECT="bigframes-testing" |
There was a problem hiding this comment.
The GOOGLE_CLOUD_PROJECT is hardcoded to bigframes-testing, which overrides the value set in the Kokoro configuration file (.kokoro/presubmit/presubmit-doctest-bigframes.cfg). This makes the configuration change to precise-truck-742 ineffective. It is recommended to use a conditional assignment to allow the configuration to control the project ID while providing a sensible default.
| export GOOGLE_CLOUD_PROJECT="bigframes-testing" | |
| export GOOGLE_CLOUD_PROJECT="${GOOGLE_CLOUD_PROJECT:-bigframes-testing}" |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕