Conversation
Resolve modify/delete conflict on docs/sources/query/_index.md by keeping the deletion (content lives in query-editor.md) and incorporating the new Commit files, Pull request files, and Include files (Commits) documentation from #654 into query-editor.md. Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Overhauls and consolidates the GitHub data source plugin documentation into a flatter, Grafana-standard page structure under docs/sources/, adding missing feature coverage (notably alerting) and expanding guidance for configuration, querying, variables, and troubleshooting.
Changes:
- Consolidates prior multi-directory docs into a smaller set of top-level docs pages with aliases for old routes.
- Adds/expands documentation for query editor behavior, template variables/macros, alerting, annotations, and troubleshooting.
- Updates the docs landing page content (requirements, capabilities, use cases, dashboards, caching, and resources).
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/sources/_index.md | Updates landing page content, adds aliases, requirements, capabilities, use cases, dashboards, caching. |
| docs/sources/configure.md | New consolidated configuration/auth/provisioning (YAML + Terraform) guide. |
| docs/sources/query-editor.md | New consolidated query editor reference across query types and response fields. |
| docs/sources/template-variables.md | New consolidated template variables + macros documentation with walkthrough examples. |
| docs/sources/annotations.md | New consolidated annotations guide with use-case examples. |
| docs/sources/alerting.md | New alerting page describing supported patterns and examples. |
| docs/sources/troubleshooting.md | New expanded troubleshooting guide for auth/connection/query/code scanning/debugging. |
| docs/sources/query/_index.md | Removes old query docs (replaced by query-editor.md + alias). |
| docs/sources/setup/_index.md | Removes old setup index (replaced by configure.md + alias). |
| docs/sources/setup/installation.md | Removes old installation page (covered by configure.md). |
| docs/sources/setup/token.md | Removes old token page (covered by configure.md). |
| docs/sources/setup/datasource.md | Removes old datasource config page (covered by configure.md). |
| docs/sources/setup/provisioning.md | Removes old provisioning page (covered by configure.md). |
| docs/sources/variables-and-macros/_index.md | Removes old variables/macros index (replaced by template-variables.md + aliases). |
| docs/sources/variables-and-macros/variables.md | Removes old variables page (replaced by template-variables.md). |
| docs/sources/variables-and-macros/macros.md | Removes old macros page (replaced by template-variables.md). |
| docs/sources/annotations/_index.md | Removes old annotations page (replaced by annotations.md + alias). |
| docs/sources/troubleshoot/_index.md | Removes old troubleshooting page (replaced by troubleshooting.md + alias). |
| docs/sources/sample-dashboards/_index.md | Removes old sample dashboards page (content merged; alias added on landing page). |
| .vscode/settings.json | Adds a VS Code workspace setting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Add missing run_started_at field to Workflow Runs response docs - Update "19 resource types" to "20+" to reflect new query types - Add .vscode/ to .gitignore Made-with: Cursor
Terraform's jsonencode function is used in the provisioning examples in configure.md. Made-with: Cursor
fabrizio-grafana
left a comment
There was a problem hiding this comment.
Overall looks really good to me, I just left I couple of comments on things we might want to double check, to ensure the documentation is up-to-date with the codebase.
|
@fabrizio-grafana, thanks for your review! I've made the requested changes, and this is ready for a re-review. |
Overhaul the GitHub data source plugin documentation to align with Grafana's official documentation standards. This restructures fragmented pages into a flat file layout, adds missing content, verifies accuracy against the codebase, and improves overall clarity and flow.
Structure changes
Consolidated 12 files across 5 directories into 7 flat files under docs/sources/:
Created new alerting.md — The plugin supports alerting (plugin.json: "alerting": true) but had no documentation for it.
Content additions