Fix store logo not appearing in PDF invoice when using absolute store URL

[Copilot]

PictureService.GetThumbUrl passed the absolute store URL into IFileStoreExtensions.Combine, which calls Path.IsPathRooted to decide whether to prepend /. Since Path.IsPathRooted("https://...") returns false, Combine produced /https://example.com/assets/images/thumbs/logo.jpg — an invalid URL that rendered as a broken image in PDF invoices.

Changes

• PictureService.GetThumbUrl: Only pass the relative thumb path to Combine; use the Uri class to properly resolve the absolute URL:

// Before
return _mediaFileStore.Combine(storeLocation, ImageThumbPath, thumbFileName);

// After
var thumbPath = _mediaFileStore.Combine(ImageThumbPath, thumbFileName);
if (string.IsNullOrEmpty(storeLocation))
    return thumbPath;

return new Uri(new Uri(storeLocation), thumbPath).ToString();

• PictureServiceTests: Added TestablePictureService subclass to expose the protected method, plus two tests covering the absolute-URL and empty store location cases.

AzurePictureService and AmazonPictureService both override GetThumbUrl with their own URL construction and are unaffected.

[Copilot]

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• ccsca2021.crl.certum.pl
  • Triggering command: /usr/share/dotnet/dotnet dotnet test src/Tests/Grand.Business.Storage.Tests/Grand.Business.Storage.Tests.csproj (dns block)
• ccsca2021.ocsp-certum.com
  • Triggering command: /usr/share/dotnet/dotnet dotnet test src/Tests/Grand.Business.Storage.Tests/Grand.Business.Storage.Tests.csproj (dns block)
• crl.certum.pl
  • Triggering command: /usr/share/dotnet/dotnet dotnet test src/Tests/Grand.Business.Storage.Tests/Grand.Business.Storage.Tests.csproj (dns block)
• subca.ocsp-certum.com
  • Triggering command: /usr/share/dotnet/dotnet dotnet test src/Tests/Grand.Business.Storage.Tests/Grand.Business.Storage.Tests.csproj (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Fixes incorrect thumbnail URL construction when storeLocation is an absolute URL (e.g., https://...), which previously produced invalid paths like /https://example.com/... and caused broken images (notably in PDF invoices).

Changes:

• Updated PictureService.GetThumbUrl to build the thumb path independently and then resolve it against storeLocation using Uri.
• Added a TestablePictureService helper to expose the protected GetThumbUrl for testing.
• Added tests covering absolute storeLocation and missing storeLocation cases.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/Business/Grand.Business.Storage/Services/PictureService.cs	Fixes URL construction by avoiding Combine with absolute URLs and using Uri to resolve correctly.
src/Tests/Grand.Business.Storage.Tests/Services/PictureServiceTests.cs	Adds regression tests for absolute store URL handling and the relative-path fallback when store location is empty/null.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.