Remove PreferredVersions functionality#1498
Merged
ysangkok merged 7 commits intohaskell:masterfrom Apr 28, 2026
Merged
Conversation
isovector
force-pushed
the
no-prefversions
branch
from
9b1e64d to
c1811f3
Compare
isovector
force-pushed
the
no-prefversions
branch
from
c1811f3 to
398d86e
Compare
isovector
commented
Apr 28, 2026
|
|
||
| data VersionStatus = NormalVersion | DeprecatedVersion | UnpreferredVersion deriving (Show, Eq, Ord, Enum) | ||
|
|
||
| $(deriveSafeCopy 0 'base ''VersionStatus) |
Contributor
Author
There was a problem hiding this comment.
Instance removed to prove that we aren't serializing this thing anywhere
isovector
commented
Apr 28, 2026
| then Nothing | ||
| else Just range | ||
|
|
||
| data VersionStatus = NormalVersion | DeprecatedVersion | UnpreferredVersion deriving (Show, Eq, Ord, Enum) |
Contributor
Author
There was a problem hiding this comment.
This was a bad merge in #1492; the type got copied into .Types but never ended up being used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the "preferred versions" part of the
PreferredVersionsfeature.My motivation for cleaning this up is to minimize the work required to accomplish #1486.
Closes #1345
Fixes #1374
After this PR, all of hackage should behave as if there were never any preferred versions.
I've replaced the cached
sumRangewith an on-demand function in order to invalidate the cache. I haven't benchmarked this, but could do something less stupid here if you think it's important.