Structured use of PkgInfo#1499
Merged
ysangkok merged 5 commits intohaskell:masterfrom Apr 28, 2026
Merged
Conversation
isovector
force-pushed
the
structured-pkginfo
branch
from
d690021 to
fe3c31e
Compare
isovector
commented
Apr 28, 2026
| , uploadtime) | ||
| | pkg <- map head pkgss | ||
| , let (_, (uploadtime, _user)) = Vec.head (pkgMetadataRevisions pkg) | ||
| , let (uploadtime, _user) = pkgLatestUploadInfo pkg |
Contributor
Author
There was a problem hiding this comment.
Note that Vec.head was the first revision; this is now the latest revision. The use of head here seemed like a bug to me, but I can keep the old behavior if desired.
isovector
force-pushed
the
structured-pkginfo
branch
from
fe3c31e to
f2633c3
Compare
isovector
force-pushed
the
structured-pkginfo
branch
from
f2633c3 to
736bd90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors all uses of
PkgInfoso as to not use the internalacid-stateselectorspkgMetadataRevisionsandpkgTarballRevisions, preferring instead high-level semantic accessors.The motivation here is be much more precise about exactly what data is required in the existing implementation. In a post
acid-stateworld, we are not going to want to fetch the state of the world and filter afterwards.Implementation note: I put this together by turning on
-XNoFieldSelectors, such that every use of the selectors became an error. I then traced through each use and rewrite in terms of projections fromDistribution.Server.Packages.Types.