fix: set JSON Content-Type when a single header is present#1821
Closed
parinporecha wants to merge 1 commit intohttpie:masterfrom
Closed
fix: set JSON Content-Type when a single header is present#1821parinporecha wants to merge 1 commit intohttpie:masterfrom
parinporecha wants to merge 1 commit intohttpie:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running
http --print=B POST pie.dev/post 'header1: xyz' x=1with a single custom header, HTTPie doesn't setContent-Type: application/jsonon the request. With two headers it works fine.Root Cause
In
httpie/client.pylines 263-275, the inner conditionif args.json or (auto_json and args.data):was redundant and wrong. It prevented Content-Type from being set whenargs.json=Falseandauto_json=Truewith data.Fix
Removed the redundant inner
ifguard. NowContent-Typeis set unconditionally inside the outerif args.json or auto_json:block.Testing
test_json_content_type_with_single_headerto verify the fixFixes #1640.