chore: Enforce no-unused-vars

[pulpdrew]

Summary

This PR makes no-unused-vars a lint error in the app package, and removes existing unused vars.

Screenshots or video

How to test locally or on Vercel

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2e896ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ready	Preview, Comment	Apr 23, 2026 1:24pm

[github-actions]

E2E Test Results

✅ All tests passed • 147 passed • 3 skipped • 1089s

Status	Count
✅ Passed	147
❌ Failed	0
⚠️ Flaky	4
⏭️ Skipped	3

Tests ran across 4 shards in parallel.

View full report →

[pulpdrew]

Replaced 3 usages of this function with lodash's omit()

[github-actions]

🟡 Tier 3 — Standard

Introduces new logic, modifies core functionality, or touches areas with non-trivial risk.

Why this tier:

• Standard feature/fix — introduces new logic or modifies core functionality

Review process: Full human review — logic, architecture, edge cases.
SLA: First-pass feedback within 1 business day.

Stats

• Production files changed: 67
• Production lines changed: 440 (+ 37 in test files, excluded from tier calculation)
• Branch: drew/lint-unused-vars
• Author: pulpdrew

To override this classification, remove the review/tier-3 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

[github-actions]

PR Review

Overall this is a clean lint enforcement PR. A couple of things worth checking:

• ⚠️ LogSidePanelElements.tsx gets a blanket /* eslint-disable @typescript-eslint/no-unused-vars */ at the top → This defeats the entire purpose of upgrading the rule to 'error'. The remaining unused vars in this file should be properly removed instead of suppressed file-wide.

• ⚠️ PodDetailsSidePanel.tsx: handleRowClick removed along with rowId and onRowClick props → The rowId state variable remains but there's no longer any code path that sets it to a non-null value. If row-click drill-down was functional, this silently removes it. Confirm this feature was already dead/broken before merging.

• ✅ useSourceMappedFrame parameter removal is fine — the hook body never used frame (always returns hardcoded stub values).

• ✅ SessionSidePanel/SessionSubpanel prop removals (generateSearchUrl, generateChartUrl, etc.) look intentional — these were marked FIXME and propagated as dead props.

• ✅ Replacing custom omit in utils.ts with lodash.omit is correct; lodash is already a project dependency.