Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
bot
added
package: angular
| // -------------------------------------------------- | ||
|
|
||
| .action-sheet-button-label { | ||
| gap: 12px; |
There was a problem hiding this comment.
I decided to use the same value that ionic uses.
| <div class="alert-button-inner"> | ||
| <div class="alert-checkbox-icon"> | ||
| <div class="alert-checkbox-inner"></div> | ||
| {inputs.map((i) => { |
There was a problem hiding this comment.
The only change is the addition of optionLabelOptions and renderOptionLabel
| <div class="alert-button-inner"> | ||
| <div class="alert-radio-icon"> | ||
| <div class="alert-radio-inner"></div> | ||
| {inputs.map((i) => { |
There was a problem hiding this comment.
The only change is the addition of optionLabelOptions and renderOptionLabel
| */ | ||
| this.closeModal(); | ||
| } | ||
| {this.options.map((option, index) => { |
There was a problem hiding this comment.
The only change is the addition of optionLabelOptions and renderOptionLabel
| onIonChange={(ev) => { | ||
| this.setChecked(ev); | ||
| this.callOptionHandler(ev); | ||
| return this.options.map((option, index) => { |
There was a problem hiding this comment.
The only change is the addition of optionLabelOptions and renderOptionLabel
| /** | ||
| * Text that is placed underneath the option text to provide additional details about the option. | ||
| */ | ||
| @Prop() description?: string; |
There was a problem hiding this comment.
Description isn't being used here to display on the screen because ion-select-option isn't used to display the options, it's done through the respective interface. So description is passed to the interface.
| <slot name="start"></slot> | ||
| <slot></slot> | ||
| <slot name="end"></slot> |
There was a problem hiding this comment.
Slots aren't being used here to display on the screen because ion-select-option isn't used to display the options, it's done through the respective interface. So slots are passed to the interface and the rendering is done with a new utility.
Even though it's not used to display here, it's still useful to include here so the docs can generate that "slots" are available for the options.
| onIonChange={(ev) => { | ||
| this.setChecked(ev); | ||
| this.callOptionHandler(ev); | ||
| return options.map((option, index) => { |
There was a problem hiding this comment.
The only change is the addition of optionLabelOptions and renderOptionLabel
| */ | ||
| this.dismissParentPopover(); | ||
| } | ||
| {options.map((option, index) => { |
There was a problem hiding this comment.
The only change is the addition of optionLabelOptions and renderOptionLabel
1 participant
Issue number: resolves #
What is the current behavior?
What is the new behavior?
Does this introduce a breaking change?
Other information