feat: introduce subinterface interface type#293
Open
sven-rosenzweig wants to merge 1 commit intomainfrom
Open
Conversation
hardikdr
added
the
area/switch-automation
sven-rosenzweig
force-pushed
the
subinterface_crd
branch
from
4cbb36d to
19d10db
Compare
sven-rosenzweig
force-pushed
the
subinterface_crd
branch
2 times, most recently
from
fd53579 to
1173387
Compare
sven-rosenzweig
force-pushed
the
subinterface_crd
branch
2 times, most recently
from
5b2dd5b to
df02964
Compare
| InterfaceTypeAggregate InterfaceType = "Aggregate" | ||
| // InterfaceTypeRoutedVLAN indicates that the interface is a routed VLAN interface (SVI/IRB). | ||
| InterfaceTypeRoutedVLAN InterfaceType = "RoutedVLAN" | ||
| // InterfaceTypeSubinterface indicates that the interface is a subinterface of a physical interface. |
Contributor
There was a problem hiding this comment.
Suggested change
| // InterfaceTypeSubinterface indicates that the interface is a subinterface of a physical interface. | |
| // InterfaceTypeSubinterface indicates that the interface is a subinterface of a interface. |
Can also be of a aggregate interface.
sven-rosenzweig
force-pushed
the
subinterface_crd
branch
from
df02964 to
6f50313
Compare
Add a new "subinterface" interface type to support Layer 3 subinterfaces. Layer 3 subinterfaces allow a single physical router interface to handle traffic from multiple VLANs by creating separate logical interfaces per VLAN. Validation rules: - Encapsulation is allowed for subinterfaces only - Supported encapsulation types: 802.1Q and 802.1ad - Validate VLAN ID range - 802.1ad requires two VLAN IDs (outer and inner VLAN) - Subinterfaces cannot be configured as aggregate, switchport, or vlanRef
felix-kaestner
force-pushed
the
subinterface_crd
branch
from
6f50313 to
21cf932
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new "subinterface" interface type to support Layer 3 subinterfaces. Layer 3 subinterfaces allow a single physical router interface to handle traffic from multiple VLANs by creating separate logical interfaces per VLAN.
Validation rules: