call NewMapperTagFunc's tagMapFunc before parsing name/options#214
Open
jlburkhead wants to merge 1 commit intojmoiron:masterfrom
Open
call NewMapperTagFunc's tagMapFunc before parsing name/options#214jlburkhead wants to merge 1 commit intojmoiron:masterfrom
jlburkhead wants to merge 1 commit intojmoiron:masterfrom
Conversation
jlburkhead
changed the title
|
I think you are right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May be I don't understand how
NewMapperTagFuncis supposed to work, but it seems like thetagMapFuncneeds to be called before these lines so that name and options are set for the field. Even if my understanding of how thetagMapFuncworks is off, the test needs to be fixed since any func (ornil) works as the third arg toNewMapperTagFuncinTestTagNameMapping.