Return string type for JSONText.Value()#306
Open
Taik wants to merge 1 commit intojmoiron:masterfrom
Open
Conversation
In order to support `binary_parameters` flag in lib/pq, we need to explicitly return string type to signal lib/pq to send the field via text format (lib/pq#528).
mngmntt
approved these changes
Jan 8, 2020
Collaborator
|
Hello, @ardan-bkennedy, and I recently stepped in to help maintain this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support
binary_parametersflag in lib/pq, we need to explicitly return string type to signal lib/pq to send the field via text format (pointed out by cbandy at lib/pq#528). This change shouldn't break backwards compatibility if binary_parameters isn't turned on.We've been testing this fork in production for a few days with pgbouncer transaction pooling mode, and so far things are working as expected.