Add error-path diagnostics for cloud-hypervisor startup#195
Open
sjmiller609 wants to merge 1 commit intomainfrom
Open
Add error-path diagnostics for cloud-hypervisor startup#195sjmiller609 wants to merge 1 commit intomainfrom
sjmiller609 wants to merge 1 commit intomainfrom
Conversation
|
Firetiger deploy monitoring skipped This PR didn't match the auto-monitor filter configured on your GitHub connection:
Reason: PR modifies cloud-hypervisor diagnostics in the hypervisor package, not kernel API endpoints or Temporal workflows as specified in the filter. To monitor this PR anyway, reply with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Notes
Note
Low Risk
Low risk: adds failure-only logging/diagnostics around Cloud Hypervisor
StartVMHTTP calls without changing the success path or VM control flow.Overview
Improves Cloud Hypervisor startup troubleshooting by emitting failure-only diagnostics when
CreateVMorBootVMrequests error or return non-204.The new diagnostics log context cancellation/deadline details, socket existence/dialability, CH process liveness, and a truncated tail of
logs/vmm.log, with response bodies/errors truncated to limit log volume.Reviewed by Cursor Bugbot for commit 126b210. Bugbot is set up for automated code reviews on this repo. Configure here.