feat(ContainerPreview): Add shulker content preview to item render in inventories#286
Merged
beanbag44 merged 4 commits intolambda-client:1.21.11from Apr 26, 2026
Conversation
Member
|
this is really cool but theres a small issue. For example, this shulker is displaying a dirt block when most of the items are pickaxes. This also happened with my signed books shulker. I assume this is because of stack size, but i think it would be better to compare, either by item count, ignoring stack size, or accounting for the maximum stack size. 
|
Contributor
Author
|
Yeah I can make it weigh item count relative to an items max stack size. But I think the current method is the same that rusherhack uses and I'm used to that. |
Member
|
maybe a mode setting for item count weight |
Clarify other code and code cleanup
beanbag44
requested changes
Apr 24, 2026
beanbag44
approved these changes
Apr 26, 2026
Member
beanbag44
left a comment
beanbag44
left a comment
There was a problem hiding this comment.
Awesome sauce, good to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds shulker content preview renders to items with containers like shulker boxes and bundles.