♻️ Add sync guard, add signal-based I/O, and rename listener#92
Merged
Conversation
709f2af to
c5e86a6
Compare
…er API This commit makes three major changes: 1. **guard class**: Converted from references to pointers with proper move semantics—moved-from objects null out both pointers. 2. **I/O state**: Renamed `blocked_by::io` and `blocked_by::external` to `blocked_by::signal` to clarify that any external events trigger unblocking. 3. **Listener API**: Renamed `unblock_listener` to `context_listener` and `on_unblock()` to `set_listener()`, plus added `on_sync_block()` callback for sync contention tracking. The changes improve semantic clarity around blocking states and make the guard type safely movable with proper cleanup semantics. Co-authored-by: Malia Labor (@MaliaLabor)
c5e86a6 to
19316b5
Compare
This was referenced Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes three major changes:
blocked_by::ioandblocked_by::externaltoblocked_by::signalto clarify that any external events trigger unblocking.unblock_listenertocontext_listenerandon_unblock()toset_listener(), plus addedon_sync_block()callback for sync contention tracking.The changes improve semantic clarity around blocking states and make the guard type safely movable with proper cleanup semantics.
Co-authored-by: Malia Labor (@MaliaLabor)