Skip to content

refactor(docker): improve Dockerfiles for authentication, graphql, subscriber, and upgrade-agents#5468

Open
1107-adishjain wants to merge 3 commits intolitmuschaos:masterfrom
1107-adishjain:dockerfile-improvements-auth-graphql
Open

refactor(docker): improve Dockerfiles for authentication, graphql, subscriber, and upgrade-agents#5468
1107-adishjain wants to merge 3 commits intolitmuschaos:masterfrom
1107-adishjain:dockerfile-improvements-auth-graphql

Conversation

@1107-adishjain
Copy link
Copy Markdown

Description:

This PR improves the Dockerfiles for the authentication, graphql, subscriber, and upgrade-agents services:

  • Remove unnecessary RUN go env step
  • Replace ADD with COPY for local context
  • Remove ENV GOOS/GOARCH, pass them directly in build command
  • Ensure LABEL maintainer is present in all stages

Proposed changes

This PR refactors the Dockerfiles for core services to improve consistency, follow best practices, and reduce unnecessary steps.
No functional changes to the services themselves.


Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)
  • Refactor (code improvement with no functional change)

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PRs that need to be merged before this (if any):

None


Special notes for your reviewer:

N/A

1107-adishjain and others added 2 commits March 28, 2026 01:16
…bscriber, and upgrade-agents

- Remove unnecessary RUN go env step
- Replace ADD with COPY for local context
- Remove ENV GOOS/GOARCH, pass them directly in build command
- Ensure LABEL maintainer is present in all stages

Signed-off-by: ADISH <adishjain1107@gmail.com>
@PriteshKiri
Copy link
Copy Markdown
Contributor

Hey @1107-adishjain

Some checks are failing. Could you please check once?

@1107-adishjain
Copy link
Copy Markdown
Author

Hey @1107-adishjain

Some checks are failing. Could you please check once?

Sure let me check once and fix it.

…d subscriber

Signed-off-by: ADISH <adishjain1107@gmail.com>
@1107-adishjain
Copy link
Copy Markdown
Author

1107-adishjain commented Apr 9, 2026

Hi @PriteshKiri , I have made the required fixes for the failing Docker CI checks in this PR.
Changes included:

Updated Go builder image to a patched version in authentication, graphql, and subscriber Dockerfiles.
Added runtime package update step (microdnf update + clean) in graphql and subscriber Dockerfiles to address OS-level CVEs.
Upgraded gRPC dependency to a fixed version in authentication, graphql, and subscriber modules.
Updated corresponding go.sum files after dependency updates.

Could you please re-run the checks? If everything passes, we can proceed with merge to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants