Fix build warnings#572
Open
cosminpolifronie wants to merge 6 commits intomachinezone:masterfrom
Open
Conversation
… do not bundle it with the library anymore
…ewer versions via ws CMakeLists - now there are no more dependencies stored in the repository
Contributor
|
There are too many changes bundled into this. Could you break it down into a few different ones, one of them being using cmake to fetch dependencies. The build is failing btw for some reason. |
Contributor
Author
|
The commits can be reviewed one by one, the changes are not big for each (they are quite small for a pull request each) and are exactly described in the commit messages. I will take another look at the builds. It seems the GH builds you have apply much stricter warning flags and error on warning. It would have been nice to have those included in the root CMakeLists.txt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were lots of build warnings on MacOS because of using lots of old dependencies.
All of them have been updated to the latest versions and removed from the repository.
All dependencies are now downloaded from GitHub, using the latest tags or commits at the time of writing.
The only remaining MacOS warning is given in AppleSSL, as SecureTransport has been deprecated since macOS 10.15.
I am not familiar with those TLS paths and there are no TLS tests in the library so I don't think I'm the right person to add a Network.framework implementation, even if AI would implement it.
I will leave that to someone who has an interest in using the newer Apple SSL framework.