Fix SelectInterruptPipe::read() being called with fd -1#573
Open
cosminpolifronie wants to merge 1 commit intomachinezone:masterfrom
Open
Fix SelectInterruptPipe::read() being called with fd -1#573cosminpolifronie wants to merge 1 commit intomachinezone:masterfrom
cosminpolifronie wants to merge 1 commit intomachinezone:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using IXWebSocket in our enterprise project, we are getting the following valgrind warning.
Pull request #503 is handling this issue by adding a check to the read location.
This pull requests fixes the root cause, where a
SelectInterruptPtris used without being initialized. ThisSelectInterruptPtris not needed at all at this moment in the code path, so it has been completely replaced with anullptr.Build and tests are passing, and also our enterprise project is not showing the valgrind warning anymore.
Also, to answer #503 (comment), the correct error return value at this place is 0, as the parent class
SelectInterruptalso returns 0 (signaling an error).https://github.com/machinezone/IXWebSocket/blob/master/ixwebsocket/IXSelectInterrupt.cpp#L36