Skip to content

MSC4163: Apply server ACLs to receipt and typing EDUs#783

Closed
sandhose wants to merge 2 commits intomainfrom
devon/acl-edus
Closed

MSC4163: Apply server ACLs to receipt and typing EDUs#783
sandhose wants to merge 2 commits intomainfrom
devon/acl-edus

Conversation

@sandhose
Copy link
Copy Markdown
Member

@sandhose sandhose commented Jun 2, 2025

@sandhose sandhose requested review from a team as code owners June 2, 2025 13:34
@sandhose sandhose marked this pull request as draft June 2, 2025 13:50
Comment on lines +96 to +98
// Bob starts typing in both rooms
bob.SendTyping(t, roomID, true, 10000)
bob.SendTyping(t, sentinelRoom, true, 10000)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like we can split the tests for PDU's vs EDU's

@FrenchGithubUser
Copy link
Copy Markdown
Contributor

Hey, I'd be interested in taking over this PR to finish what has to be done. Is this ok for you @sandhose ? :)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I'd be interested in taking over this PR to finish what has to be done. Is this ok for you [...] ? :)

-- @FrenchGithubUser, #783 (comment)

Sounds fine 👍 - I assume that means you creating a new PR.

(better to comment on the diff so we can thread the discussion)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> #862

@MadLittleMods
Copy link
Copy Markdown
Collaborator

Closing in favor of #862

@MadLittleMods MadLittleMods deleted the devon/acl-edus branch April 24, 2026 23:10
MadLittleMods added a commit to element-hq/synapse that referenced this pull request Apr 25, 2026
Implements: [MSC4163: Make ACLs apply to
EDUs](matrix-org/matrix-spec-proposals#4163)

Part of #18118 to declare support for Matrix v1.13

Complement PR: ~~matrix-org/complement#783 ->
matrix-org/complement#862


---------

Co-authored-by: Eric Eastwood <erice@element.io>
Co-authored-by: Quentin Gliech <quenting@element.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants